Skip to content

[INFRANG-6876] Upgrade to go 1.24 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

[INFRANG-6876] Upgrade to go 1.24 #180

merged 2 commits into from
Apr 18, 2025

Conversation

andruwm
Copy link
Contributor

@andruwm andruwm commented Apr 16, 2025

JIRA

https://clever.atlassian.net/browse/INFRANG-6876

About

This PR upgrades this repo to Go version 1.24. See the release notes for full details.

It performs the following changes:

  1. Upgrade the module to 1.24.
  2. Upgrade the golang.mk file to the latest version.
  3. Replaces any tools.go file with the new go.mod tools directive.
  4. Updates any circle CI build images to 1.24.
  5. Updates the go version check in the makefile.
  6. Updates any debian docker images to a version with a glibc compatible with the CI build image.

New Go Vet Check

Go vet in 1.24 introduces a new check which catches non-constant format strings in calls to printf functions. This has a tendency to find bugs in existing code, however the fix is pretty strait forward should your CI begin to fail. You can see more details in the official issue golang/go#60529. If your CI fails because of this, you may add an extra commit resolving the issue, then merge. The microplane script attempts to resolve as many of these cases as possible automatically.

Testing

Go version upgrades have historically been extremely stable. The only exception has been incompatible glibc versions which have been tested for in workers before merging. All standard CI testing is also performed before merging.

Problems Upgrading?

Checkout this google doc for knowledge sharing any problems you encounter during upgrades!

@andruwm andruwm requested a review from a team as a code owner April 16, 2025 21:31
@andruwm andruwm requested review from taylor-sutton and removed request for a team April 16, 2025 21:31
@andruwm andruwm merged commit bcd19fb into master Apr 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants