Fix e2e test cleanup: log drains deletion and reliability improvements #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 3, 2026 09:59
When a resource is already gone or a deletion fails, Promise.all short-circuits and skips remaining cleanup tasks. Using allSettled ensures all resources are attempted for deletion independently.
API response times can vary significantly, causing e2e tests to fail intermittently with the previous limits.
pdesoyres-cc
force-pushed
the
e2e-log-drains-cleanup
branch
from
8a27a76 to
5ae7907
Compare
Galimede
approved these changes
Feb 9, 2026
Member
Galimede
left a comment
Galimede
left a comment
There was a problem hiding this comment.
Hey Pierre, just two quick questions but LGTM, thanks for handling that! 💪
| ); | ||
| if (drains.length > 0) { | ||
| await Promise.allSettled( | ||
| drains.map((drain) => |
Member
There was a problem hiding this comment.
question: We don't seem to use the array after the map, do we really need to use map?
| }, | ||
| }, | ||
| testsFinishTimeout: 1000 * 60 * 10, | ||
| testsFinishTimeout: 1000 * 60 * 20, |
Member
There was a problem hiding this comment.
question: what's the difference between timeout and testsFinishTimeout? Before it was all set to 10 seconds now we have both 20 and 30 seconds, but i'm not sure I understand what one or the other does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The e2e test suite creates applications with log drains attached during log command tests. After tests complete, the cleanup phase tears down all created resources (applications, addons, organisations, etc.).
Problem
Log drains created during tests were not being cleaned up because the API does not automatically delete them when the application is deleted. This left orphaned log drains behind after each test run.
Additionally, cleanup used
Promise.allwhich would abort early on the first rejection, meaning subsequent resources were never cleaned up. Test timeouts were also too low for slow API responses, causing spurious failures.The access log test asserted
typeas"http"but the API actually returns"https".Solution
Promise.alltoPromise.allSettledin all cleanup functions so that a single failure doesn't prevent other resources from being cleaned up.