Skip to content

Conversation

@florian-sanders-cc
Copy link
Contributor

Fixes #1245

What does this PR do?

  • Fixes Type Checking issues in the .storybook folder and related libs,
  • Adds the .storybook to the list of files to type check (both in editors & CI).

How to review?

  • Checking the code should be enough,
  • 1 reviewer is enough for this one

@florian-sanders-cc florian-sanders-cc self-assigned this Dec 11, 2024
@github-actions
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/storybook/typecheck-related-libs/index.html.

This preview will be deleted once this PR is closed.

@florian-sanders-cc florian-sanders-cc marked this pull request as ready for review December 11, 2024 13:58
Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM!

@florian-sanders-cc florian-sanders-cc force-pushed the storybook/typecheck-related-libs branch from 905ee72 to 3196927 Compare December 17, 2024 15:24
@florian-sanders-cc florian-sanders-cc merged commit 1b6862d into master Dec 17, 2024
4 checks passed
@florian-sanders-cc florian-sanders-cc deleted the storybook/typecheck-related-libs branch December 17, 2024 15:43
@github-actions
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typecheck the .storybook/ folder

2 participants