-
Notifications
You must be signed in to change notification settings - Fork 23
Docs: Add ADR about Type Checking #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/docs/adr-typechecking/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ADR!
A couple small corrections to make. 😉
HeleneAmouzou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! 👏 Nothing more to add than the comments @roberttran-cc already made !
hsablonniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ADR!!! 👏
- The build step is only here to optimize the code of the components.
Not sure if we really want to but there's an opportunity to mention bare imports. Our source files need a bundling phase to handle such bare imports. Nowadays, they could work as is but with import maps.
Include a note about this if you think it's relevant 😉
Galimede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ADR is great, GG Florian! 💪
I have maybe a small suggestion, we do refer to some tools like lit-analyzer or CEM, maybe we could add a section with a link to these projects or add a link directly where they are first mentioned? 🤔
pdesoyres-cc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Well done Florian.
334ab1c to
916b32e
Compare
Good idea! I always forget about import maps because last time I played with them I found them not very convenient. |
Good idea! I chose to add direct links to the projects within the sentences instead of adding a separate section |
916b32e to
d3eb1da
Compare
fixes have been applied (thanks again!), no need to check again
|
🔎 The preview has been automatically deleted. |
What does this PR do?