chore(storybook): switch to static Clever App #1287
Merged
+37
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
force-pushed
the
storybook/switch-to-clever-static-app
branch
3 times, most recently
from
e961265 to
0a313ed
Compare
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/storybook/switch-to-clever-static-app/index.html. This preview will be deleted once this PR is closed. |
- Remove the `node-static` dependency, - Remove the `start` npm script, - Add `.htaccess` to be used by the static Clever App (Apache server), - Adapt the storybook build process to copy the `.htaccess` file to the `storybook-static` directory. Fixes #1280
florian-sanders-cc
force-pushed
the
storybook/switch-to-clever-static-app
branch
from
0a313ed to
30bfb4b
Compare
pdesoyres-cc
approved these changes
Dec 19, 2024
Contributor
pdesoyres-cc
left a comment
pdesoyres-cc
left a comment
There was a problem hiding this comment.
LGTM. Well done.
The option you chose for the .htaccess file handling is ok for me.
roberttran-cc
approved these changes
Dec 19, 2024
Member
roberttran-cc
left a comment
roberttran-cc
left a comment
There was a problem hiding this comment.
Thanks for handling this! And I agree with the choice you made for the .htaccess.
Contributor
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1280
What does this PR do?
node-staticdependency,startnpm script,.htaccessto be used by the static Clever App (Apache server).How to review?
npm run storybook:buildlocally and check that thestorybook-staticdirectory contains a.htaccess.Things to discuss
To make Apache handle the SPA correctly & specify cache rules, we need a
.htaccessfile.This
.htaccessfile needs to be placed at the root of the directory served by the server (CC_WEBROOT) which isstorybook-static.We cannot simply put the
.htaccessinstorybook-staticourselves because this directory is removed & created by the storybook build command (+ it's git ignored anyway).We have two options:
.htaccessfile instorybook-static(the option I chose in this PR),CC_POST_BUILD_HOOKto move the.htaccessfile in thestorybook-staticdirectory only when building on Clever Cloud.The option I've chosen has 1 advantage: you cannot forget to add this step, it's part of the build process.
It also has 1 disadvantage: we send
.htaccessfiles even for previews which is useless because they are served by Cellar.