fix(cc-kv-terminal): handle huge command history using lit-virtualizer #1292
Conversation
|
Special thanks to @florian-sanders-cc for helping me on this ! ❤️ |
pdesoyres-cc
requested review from
Galimede,
HeleneAmouzou,
clara-layus-cc,
florian-sanders-cc and
roberttran-cc
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-kv-terminal/virtualizer-test/index.html. This preview will be deleted once this PR is closed. |
There was a problem hiding this comment.
Gg @pdesoyres-cc !
I've left two suggestions but these are really personal preferences so feel free to ignore.
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
Actually I forgot to pull before testing on browsers, it seems it doesn't scroll to the last line at the moment 😞
We can discuss in sync if you need to see what's happening. It was working fine when you first sent me the commit you had modified so that's really weird?
pdesoyres-cc
force-pushed
the
cc-kv-terminal/virtualizer-test
branch
from
e6950e1 to
737d82a
Compare
|
You beat the boss, seems to work fine now! Great job @pdesoyres-cc 😎 |
roberttran-cc
left a comment
roberttran-cc
left a comment
There was a problem hiding this comment.
If it works, it works. 🤷
GG for handling this!
pdesoyres-cc
force-pushed
the
cc-kv-terminal/virtualizer-test
branch
from
737d82a to
43cfdba
Compare
pdesoyres-cc
force-pushed
the
cc-kv-terminal/virtualizer-test
branch
from
43cfdba to
2b89f01
Compare
|
🔎 The preview has been automatically deleted. |
3 participants
What this PR do ?
This PR moves the history of commands and their results into a lit virtualizer so that browser can handle huge command history.
How to review ?
commandto get huge result output