Skip to content

Conversation

@pdesoyres-cc
Copy link
Contributor

@pdesoyres-cc pdesoyres-cc commented Dec 12, 2025

This PR introduces a new cc-cellar-explorer component along with several supporting components (cc-breadcrumbs, cc-grid, cc-drawer) that enable browsing and managing Cellar storage. It also includes enhancements to existing components and utilities.

Changes by Commit

  • chore(dependencies): upgrade baseline-browser-mapping to version 2.9.11
    • because stylelint integration in webstorm was complaining about the old version we were using
  • docs(resize-controller): fix JSDoc of the resize callback
  • feat(cc-clipboard): add skeleton state
  • feat(cc-clipboard): enable focus delegation
  • feat(cc-button): enable focus delegation
    • Replaces the focus() implementation
  • feat(cc-grid): init component
  • Created new cc-grid component for displaying tabular data
  • Features include:
    • Column sorting (ascending/descending)
    • Keyboard navigation
    • Sticky header
  • feat(cc-drawer): init component
    • Introduced new cc-drawer component for slide-out panels
    • First very simple implementation
  • feat(cc-cellar-explorer): init component
    • This is the first iteration with buckets management only
    • Features:
      • Grid-based buckets listing
      • Filtering
      • Bucket creation
      • Bucket deletion
    • A bit of complexity because of the object listing coming in a future PR
      • a separate component: cc-bucket-list
      • a separate controller used in cc-cellar-explorer smart

@pdesoyres-cc pdesoyres-cc force-pushed the cellar-explorer branch 9 times, most recently from 8251786 to 17deb71 Compare December 19, 2025 16:54
@github-actions
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cellar-explorer/index.html.

This preview will be deleted once this PR is closed.

@pdesoyres-cc pdesoyres-cc marked this pull request as ready for review December 19, 2025 17:08
@florian-sanders-cc florian-sanders-cc self-requested a review January 6, 2026 08:38
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @pdesoyres-cc I can't wait to see this in prod, I'm sure users will enjoy this a lot, and it's only the first iteration 🙌

I found a few issues but you'll see they are pretty trivial.
Huge props for your awesome work on accessibility and the code quality in general 😉

Copy link
Contributor

@HeleneAmouzou HeleneAmouzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing much to add to what Florian already noticed. I mostly have questions.
GG for this impressive first iteration ! 👏

Copy link
Member

@roberttran-cc roberttran-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work, once again. The UX is really nice, a11y is great, and features are carefully though-out.

I approve the PR although I have two issues while testing the component in the console:

  • consecutive errors in the bucket creation form makes it buggy,
  • filter form does not appear/disappear immediately on bucket creation/deletion (must refresh page).

But really really great job.

@roberttran-cc
Copy link
Member

Tested on staging, my two issues are fixed, LGTM!

On the other hand, I've got an UI bug just after a bucket creation on a narrow screen (see screenshot below).

image

@pdesoyres-cc pdesoyres-cc force-pushed the cellar-explorer branch 2 times, most recently from 88d09d0 to 8b7940d Compare January 26, 2026 15:49
@pdesoyres-cc
Copy link
Contributor Author

Nice catch @roberttran-cc . I forgot to apply the visibility of columns during render. It should be fixed now.

@pdesoyres-cc pdesoyres-cc merged commit 92e4ba6 into master Jan 27, 2026
7 checks passed
@pdesoyres-cc pdesoyres-cc deleted the cellar-explorer branch January 27, 2026 15:13
@github-actions
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants