-
Notifications
You must be signed in to change notification settings - Fork 23
feat(cc-cellar-explorer): init component #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8251786 to
17deb71
Compare
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cellar-explorer/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @pdesoyres-cc I can't wait to see this in prod, I'm sure users will enjoy this a lot, and it's only the first iteration 🙌
I found a few issues but you'll see they are pretty trivial.
Huge props for your awesome work on accessibility and the code quality in general 😉
HeleneAmouzou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nothing much to add to what Florian already noticed. I mostly have questions.
GG for this impressive first iteration ! 👏
src/components/cc-cellar-bucket-list/cc-cellar-bucket-list.types.d.ts
Outdated
Show resolved
Hide resolved
roberttran-cc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work, once again. The UX is really nice, a11y is great, and features are carefully though-out.
I approve the PR although I have two issues while testing the component in the console:
- consecutive errors in the bucket creation form makes it buggy,
- filter form does not appear/disappear immediately on bucket creation/deletion (must refresh page).
But really really great job.
17deb71 to
647d493
Compare
88d09d0 to
8b7940d
Compare
|
Nice catch @roberttran-cc . I forgot to apply the visibility of columns during render. It should be fixed now. |
Replaces the custom `focus()` implementation
8b7940d to
cb06a97
Compare
|
🔎 The preview has been automatically deleted. |

This PR introduces a new
cc-cellar-explorercomponent along with several supporting components (cc-breadcrumbs,cc-grid,cc-drawer) that enable browsing and managing Cellar storage. It also includes enhancements to existing components and utilities.Changes by Commit
baseline-browser-mappingto version 2.9.11skeletonstatecc-gridcomponent for displaying tabular datacc-drawercomponent for slide-out panelscc-bucket-listcc-cellar-explorersmart