fix(logs): refactor buffering to use time-based throttling only #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdesoyres-cc
requested review from
Galimede,
HeleneAmouzou,
clara-layus-cc,
florian-sanders-cc,
hsablonniere and
roberttran-cc
pdesoyres-cc
force-pushed
the
logs/ff-issue
branch
2 times, most recently
from
dc78f01 to
7c63cb1
Compare
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/logs/ff-issue/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
approved these changes
Jan 6, 2026
Member
roberttran-cc
left a comment
roberttran-cc
left a comment
There was a problem hiding this comment.
Although I'm not sure it there are possible side effects, I tested this fix (comparing with & without it) and worked well for me. GG!
Galimede
approved these changes
Jan 6, 2026
Member
Galimede
left a comment
Galimede
left a comment
There was a problem hiding this comment.
Hey Pierre, I tried to test it in the sandbox but whether with or without the fix my firefox wasn't crashing. So, I tested it locally in the console right away and it works fine. 😄
Thanks for the fix and GG, LGTM! 💪
Remove size-based buffer limit in favor of time-based throttling. Reduce buffer timeout from 1s to 500ms. Fixes #1627
pdesoyres-cc
force-pushed
the
logs/ff-issue
branch
from
7c63cb1 to
448b784
Compare
Contributor
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
Fixes #1627
Context: Logs UI lags and sometimes crashes when many logs are coming fast. This occurs on firefox only ( and also when dev tools are not opened)
The proposed solution is to removes that stress on the cc-logs refresh process by removing the size-based buffer limit in favor of time-based limit only.
How to review