Add-ons dashboards fixes #1645
Merged
Add-ons dashboards fixes #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeleneAmouzou
changed the title
HeleneAmouzou
force-pushed
the
dashboard-addons/fixes
branch
5 times, most recently
from
a08e603 to
770e019
Compare
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/dashboard-addons/fixes/index.html. This preview will be deleted once this PR is closed. |
HeleneAmouzou
force-pushed
the
dashboard-addons/fixes
branch
7 times, most recently
from
c3d988c to
5bcf573
Compare
HeleneAmouzou
force-pushed
the
dashboard-addons/fixes
branch
from
5bcf573 to
9bae8b1
Compare
Contributor
🧐 Visual tests report for PR #1645The latest visual tests report is available. Please review the results.
2 components impacted
This comment was generated automatically by the Visual tests workflow. |
florian-sanders-cc
requested changes
Jan 12, 2026
Contributor
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
Everything works fine !
I just have a few notes and nitpicks about commits:
* 9bae8b13 refactor(addon-info.stories): remove billing section from Pulsar info block => I would go for a `feat`
* 7675915b refactor(cc-addon-credentials-beta.smart-elastic): remove doc link => I would go for a `feat`
* ec4e2360 refactor(cc-addon-*.smart-elastic): display `APM` before `Kibana` => I would go for a `feat`
* 85154eec fix(cc-addon-info.smart-elastic): use `realId` in Granafa link => I would go for a `fix` and maybe talk about the actual consequence like `redirect to the proper Grafana dashboard` (and in the commit body explain why it was broken before)
* 29fcc738 refactor(cc-addon-info.smart-elastic): remove `scalability` => I would go for a `feat`
* d70fbc74 refactor(cc-addon-credentials-beta*): add `api` and `cli` tabs in Pulsar credentials block => I would go for a `feat`
* 7990725f refactor(cc-addon-credentials-beta.smart-pulsar): move `tenant/namespace` before `token` => I would go for a `feat`
* d8400908 refactor(cc-addon-info): move `Creation date` up => I would go for a `feat`
* 42ee17f9 refactor(cc-addon-info.*)!: rework features section => I would go for a `feat` (especially since breaking change)
* b533b9ff refactor(cc-addon-info.smart-config-provider): remove smart component for Config Provider => I would go for a `feat` + breaking change since we already have another breaking
* 91baf119 refactor(cc-addon-credentials-beta.*): remove the doc link in Materia access block => I would go for a `feat`
src/components/cc-addon-credentials-beta/cc-addon-credentials-beta.js
Outdated
Show resolved
Hide resolved
HeleneAmouzou
force-pushed
the
dashboard-addons/fixes
branch
5 times, most recently
from
0d5374b to
b35cbd4
Compare
florian-sanders-cc
approved these changes
Jan 13, 2026
Contributor
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
All good, I've tested every component for every product impacted in demo-smart and everything looked fine!
Great work @HeleneAmouzou !
…r Config Provider
- Rename `Features` to `Specifications` - Move `plan` in `Specifications` - Extract `Encryption at rest` - Update stories
…credentials block
…irect to the proper dashboard The link used to redirect to the Kibana's Grafana whereas the is a dedicated Grafana dashboard for Elastic.
HeleneAmouzou
force-pushed
the
dashboard-addons/fixes
branch
from
b35cbd4 to
9375320
Compare
Contributor
|
🔎 The preview has been automatically deleted. |
Contributor
🧹 Visual Changes Report deletedThe report and its associated data have been deleted because this PR has been closed. This comment was generated automatically by the Visual Changes workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes feedbacks on all add-ons dashboards.
How to review?