Skip to content

Add-ons dashboards fixes #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HeleneAmouzou merged 3 commits into from
Jan 16, 2026
Merged

Add-ons dashboards fixes #1647

HeleneAmouzou merged 3 commits into from
Jan 16, 2026

Conversation

@HeleneAmouzou
Copy link
Contributor

@HeleneAmouzou HeleneAmouzou commented Jan 15, 2026 •
edited
Loading

What does this PR do ?

  • Rework cc-env-var-form.description.config-provider translations :
    • Add missing word in the french translation,
    • Update the english translation.
  • Rework cc-addon-credentials-content.code.http-url translations : change URL:port to URL,

How to review ?

  • Check the story in the preview,
  • 1 reviewer is enough.

@HeleneAmouzou HeleneAmouzou force-pushed the cc-env-var-form/fix-translation branch from 2179974 to bca4c78 Compare January 15, 2026 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-env-var-form/fix-translation/index.html.

This preview will be deleted once this PR is closed.

@HeleneAmouzou HeleneAmouzou self-assigned this Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

🧐 Visual tests report for PR #1647

The latest visual tests report is available. Please review the results.

2 components impacted
  • cc-product-card,
  • cc-env-var-form,

This comment was generated automatically by the Visual tests workflow.

florian-sanders-cc
florian-sanders-cc approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, sorry I missed that during last review 🙈

@HeleneAmouzou HeleneAmouzou changed the title refactor(translation): rework cc-env-var-form.description.config-provider translations Add-ons dashboard refactors Jan 16, 2026
@HeleneAmouzou HeleneAmouzou force-pushed the cc-env-var-form/fix-translation branch 2 times, most recently from b5f70b5 to 8191f1c Compare January 16, 2026 10:27
florian-sanders-cc
florian-sanders-cc requested changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only noticing this now: the first commit should be a fix since there was a missing word in the french translation 🙈

Apart from that it's great! 😎

@HeleneAmouzou
fix(translation): rework `cc-env-var-form.description.config-provider…
78ec8b2 
…` translations

  - Add missing word in the french translation,
  - Update the english translation.
@HeleneAmouzou
fix(cc-addon-credentials-beta.smart-pulsar): use url credential code
67a3e88 
  - use `url` credential code instead of `httpUrl`,
  - delete used `httpUrl` credential code
@HeleneAmouzou
fix(cc-addon-info.smart-elastic): use _getGrafanaClusterLink to red…
f3210a7 
…irect to the proper dashboard

The link used to redirect to the Elasticsearch application runtime's Grafana
whereas it should redirect to the Elasticsearch cluster's Grafana.
@HeleneAmouzou HeleneAmouzou force-pushed the cc-env-var-form/fix-translation branch from 8191f1c to f3210a7 Compare January 16, 2026 11:04
@HeleneAmouzou HeleneAmouzou changed the title Add-ons dashboard refactors Add-ons dashboard fixes Jan 16, 2026
@HeleneAmouzou HeleneAmouzou changed the title Add-ons dashboard fixes Add-ons dashboards fixes Jan 16, 2026
@HeleneAmouzou HeleneAmouzou merged commit 5596f2f into master Jan 16, 2026
11 checks passed
@HeleneAmouzou HeleneAmouzou deleted the cc-env-var-form/fix-translation branch January 16, 2026 11:17
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

🔎 The preview has been automatically deleted.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

🧹 Visual Changes Report deleted

The report and its associated data have been deleted because this PR has been closed.

This comment was generated automatically by the Visual Changes workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florian-sanders-cc florian-sanders-cc florian-sanders-cc requested changes

Assignees

@HeleneAmouzou HeleneAmouzou

Labels

run-visual-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HeleneAmouzou @florian-sanders-cc