Skip to content

feat(pricing): update Pulsar plan intervals and pricing logic #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
florian-sanders-cc merged 1 commit into from
Jan 23, 2026
Merged

feat(pricing): update Pulsar plan intervals and pricing logic #1654

florian-sanders-cc merged 1 commit into from
Jan 23, 2026

Conversation

@florian-sanders-cc
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc commented Jan 21, 2026 •
edited
Loading

What does this PR do?

  • Updates cc-pricing-product-consumption (and its dependencies) to:
    • add hot vs cold storage sections,
    • make pricing progressive since that's how it's billed (since december),
    • update fixtures to stay up to date with pricing (not very important, mostly a copy / paste for stories).

How to review?

  • Review all files except Fixtures (the fixtures files are mostly copy / paste from API + formatting, and their result is visible in the stories so it's better to focus on the visible result than getting lost in the modified lines),
  • Check the pricing stories in preview,
  • Run storybook locally and check http://localhost:6006/demo-smart/cc-pricing-page/ at the very bottom of the page and play with the pulsar part,
  • 2 reviewers should be enough (but I need @Galimede 's review 👀)

@florian-sanders-cc florian-sanders-cc self-assigned this Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026 •
edited
Loading

🧐 Visual tests report for PR #1654

The latest visual tests report is available. Please review the results.

5 components impacted
  • cc-product-card,
  • cc-pricing-estimation,
  • cc-pricing-product-consumption,
  • cc-pricing-product,
  • cc-pricing-page,

This comment was generated automatically by the Visual tests workflow.

@florian-sanders-cc florian-sanders-cc force-pushed the pricing/update-pulsar branch 2 times, most recently from 7dee63c to 0eb0a29 Compare January 21, 2026 08:43
pdesoyres-cc
pdesoyres-cc previously requested changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling that.

As you can see in that screenshot, the price group highlighting is missing on Pulsar

Image

@florian-sanders-cc
Copy link
Contributor Author

florian-sanders-cc commented Jan 21, 2026

@pdesoyres-cc it's not a bug it's a feature I believe 😆 :
Cellar pricing is not progressive so when you consume 15To, you don't benefit from the free tier and only the current price interval is used.
This is why the price interval is "highlighted" in this mode and not in progressive because in progressive, all tiers add up.

To be honest, I've always been confused by that, I'm not a huge fan of this UX but I don't know how to "quick fix" this.

Galimede
Galimede approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@Galimede Galimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling this Florian! 💪

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/pricing/update-pulsar/index.html.

This preview will be deleted once this PR is closed.

@florian-sanders-cc florian-sanders-cc dismissed pdesoyres-cc’s stale review January 23, 2026 08:27

Feedback has been processed!

@florian-sanders-cc
feat(pricing): update Pulsar plan intervals and pricing logic
ca01933 
- Renamed service keys to use dot notation (e.g., pulsar.throughput.in)
- Added progressive flag to inbound/outbound traffic and storage sections
- Updated interval ranges and prices for Pulsar traffic and storage plans
- Changed hot/cold storage pricing formulas for consistency
- Improved variable naming in interval rendering logic for clarity
@florian-sanders-cc florian-sanders-cc merged commit 14144d7 into master Jan 23, 2026
11 checks passed
@florian-sanders-cc florian-sanders-cc deleted the pricing/update-pulsar branch January 23, 2026 08:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🧹 Visual Changes Report deleted

The report and its associated data have been deleted because this PR has been closed.

This comment was generated automatically by the Visual Changes workflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Galimede Galimede Galimede approved these changes

@pdesoyres-cc pdesoyres-cc pdesoyres-cc left review comments

Assignees

@florian-sanders-cc florian-sanders-cc

Labels

run-visual-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florian-sanders-cc @Galimede @pdesoyres-cc