refactor: migrate to ES2023 array methods #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom findLastIndex() with native Array.prototype.findLastIndex()
roberttran-cc
force-pushed
the
refactor/es2023-migration
branch
from
fe29add to
bbf14f7
Compare
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/refactor/es2023-migration/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
force-pushed
the
refactor/es2023-migration
branch
from
bbf14f7 to
afa48b0
Compare
Replace copy-before-sort pattern with ES2023 toSorted() in 16 files
roberttran-cc
force-pushed
the
refactor/es2023-migration
branch
from
afa48b0 to
777a1b2
Compare
Contributor
🧐 Visual tests report for PR #1664The latest visual tests report is available. Please review the results.
1 components impacted
This comment was generated automatically by the Visual tests workflow. |
florian-sanders-cc
approved these changes
Jan 30, 2026
Contributor
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for handling @roberttran-cc
Contributor
🧹 Visual Changes Report deletedThe report and its associated data have been deleted because this PR has been closed. This comment was generated automatically by the Visual Changes workflow. |
Contributor
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1656
What does this PR do?
[...arr].sort()with nativearr.toSorted()across 12 files,findLastIndexpolyfill fromsrc/lib/utils.jsin favor of nativeArray.prototype.findLastIndex(),How to review?