feat(logs): migrate add-on logs from v2 to v4 API #1032
+159
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 A preview has been automatically published! If you created the alias to the preview script, you can run this command to download and install this preview: clever-preview update addon-logs-v2-to-v4You can also run it from your local repository: ./scripts/preview.js update addon-logs-v2-to-v4
This preview will be deleted once this PR is closed. |
hsablonniere
force-pushed
the
addon-logs-v2-to-v4
branch
from
82548c8 to
9de5eb7
Compare
florian-sanders-cc
approved these changes
Feb 2, 2026
Contributor
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
Tested the command with a redis and it worked fine 👍
The code LGTM!
pdesoyres-cc
requested changes
Feb 5, 2026
Contributor
pdesoyres-cc
left a comment
pdesoyres-cc
left a comment
There was a problem hiding this comment.
Nearly there, I've experienced a strange issue (that was present on application logs before this PR)
Use ResourceLogStream for addon logs instead of the v2 API. This enables all log formats (human, json, json-stream) for add-ons.
Now that the v2 log API is gone, rename the file to its original name.
hsablonniere
force-pushed
the
addon-logs-v2-to-v4
branch
from
9de5eb7 to
24c094b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The add-on logs endpoint is currently using the v2 API. The v4 API relies on a more modern stack, making it the preferred choice going forward.
Proposal
log-v4.jstolog.jssince v4 is now the standardlog-v4.jsfile (now consolidated intolog.js)Note
Temporarily, the service filter has been set to
allin a separate commit (chore: wip add service all). This is a work in progress and may need further refinement.Test plan
TODO
service=all