fix(addon): fix Matomo add-on creation #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 The preview has been automatically deleted. |
florian-sanders-cc
approved these changes
Feb 5, 2026
Contributor
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
LGTM, some suggestions to match our conventions & make it slightly more robust but it could be merged as it is (tested locally as well just in case 😉)
florian-sanders-cc
previously requested changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Ah! Forgot to check the commit message: Could we reword it so that users (not contributors to this project) understand the issue that it fixes for them? (Again, this is an issue with using our conventional commits for changelog, consumers don't expect the same info as reviewers / contributors)
Something that would mention that we've fixed Matomo addon creation 🤔
pdesoyres-cc
requested changes
Feb 5, 2026
hsablonniere
force-pushed
the
fix-1042-matomo-operator
branch
2 times, most recently
from
e13b7b5 to
d0519d6
Compare
hsablonniere
changed the title
hsablonniere
changed the title
Matomo add-on creation was failing with a 404 error due to incorrect API path construction. This fix ensures the correct provider ID is used for operator API calls.
hsablonniere
force-pushed
the
fix-1042-matomo-operator
branch
from
d0519d6 to
3f20b65
Compare
pdesoyres-cc
approved these changes
Feb 5, 2026
hsablonniere
dismissed
florian-sanders-cc’s stale review
Pierre said it was OK 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1042
Context
Creating a Matomo addon failed with a 404 error because the operator API path was constructed incorrectly. The v4 operator APIs use paths like
/v4/addon-providers/addon-${provider}/addons/..., which adds anaddon-prefix. Forproviders like
addon-matomo, passing the full provider name resulted inaddon-addon-matomo.This inconsistency in provider naming only affects Matomo among the operators (keycloak, metabase, otoroshi don't have the
addon-prefix in their keys).Solution
Replace the
isOperatorboolean with an explicitoperatorProviderstring that specifies the exact provider name to use in API calls. This allows each provider to declare the correct string needed for the operator API path, avoiding the duplicate prefix issue.addon-matomo→operatorProvider: 'matomo'keycloak→operatorProvider: 'keycloak'(unchanged behavior)kv,addon-pulsar) simply omit the property