Skip to content

fix(login): continue when browser launch fails #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atyrode wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(login): continue when browser launch fails #1111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3665485
fix(login): continue when browser launch fails
atyrode Jul 13, 2026
1ff6cce
Apply suggestions from code review
atyrode Jul 15, 2026
67d10b2
style(login): normalize line endings
atyrode Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/commands/login/login.command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,17 @@ async function loginViaConsole(apiHost, consoleTokenUrl) {

Logger.debug('Try to login to Clever Cloud…');
Logger.println(`Opening ${styleText('blue', consoleUrl.toString())} in your browser to log you in…`);
await open(consoleUrl.toString(), { wait: false });
function warnBrowserLaunchFailed(error) {
Logger.warn(`Failed to open your browser automatically (${error.message}).`);
Logger.println('Open the URL above manually to continue logging in.');
}

try {
const browserProcess = await open(consoleUrl.toString(), { wait: false });
browserProcess.once('error', warnBrowserLaunchFailed);
} catch (error) {
warnBrowserLaunchFailed(error);
}

return pollOauthData(cliPollUrl.toString());
}
Expand Down