feat(make-default): parse alias to detect if it's an appId #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
hsablonniere
requested changes
Jun 6, 2025
Member
hsablonniere
left a comment
hsablonniere
left a comment
There was a problem hiding this comment.
@aurrelhebert I don't understand this PR. make-default expects an app alias. Your PR allows the alias to also be an app ID but without documenting the behaviour. This is confusing. I think we should discuss this, I'm not sure I understand why we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in
make-defaultcommandapp_UUIDparsing support to update the local default