Skip to content

Conversation

@juliamrch
Copy link
Contributor

@juliamrch juliamrch commented Nov 13, 2024

Describe your PR

Summarize your changes here : explain what, how, and why. Be as explicict as you can on why your changes are needed and avoid implicit reasoning.

  • PREVIEW
  • PREVIEW with cc staging website
    GitHub Action executes the workflow from the base branch, which won't be changed for security reasons. Hence, preview links in the comments aren't accurate, but the preview is accessible from previw-link/developers.

Main changes

Instead of hosting the static files in /public, they're hosted in /public/developers to create a route that will allow us to perform path routing from www.clever-cloud.com. Final domain for the doc should become www.clever-cloud.com/developers. For this reason, it's been opted in the following cases:

  • When the shortcode was already in use
  • When the path contained +3 levels (error prone)

Considerations

Replacing markdown links by Hugo links: [value](link] => [value]({{< ref "file" >}}) gives more freedom to keep moving files and restructured as needed in the future, but anchors the doc in Hugo. If we want to change the stack in the future, we'll need to modify every link.

Locations where the paths have been reworked/checked in /content:

  • doc
    • /doc/*
    • guides/*
  • shortcodes (/layouts/shortcodes/content)
    • /doc/*
    • guides/*
    • specific languages (/layouts/shortcodes/content/language-specific-deploy)
      • /doc/*
      • guides/*
  • guides
    • /doc/**
    • guides/*
  • changelog
    • /doc/*
    • guides/*

Checklist

  • My PR is related to an opened issue : not indicated in the project, but coming from internal request.
  • I've read the contributing guidelines

Tasks before merge

  • Add to Ahrefs
  • Fix 404 after Ahrefs audit
  • Create prefix routing on prod app
  • Redirect developers.clever-cloud.com => www.clever-cloud.com/developers
  • Update GitHub action domain

Tasks after merge

  • Delete developers.clever-cloud.com from prod app

Reviewers

Who should review these changes? @

@github-actions
Copy link

Deployment has finished 👁️👄👁️ Your app is available here

@juliamrch juliamrch self-assigned this Nov 13, 2024
@juliamrch juliamrch added the enhancement New feature or request label Nov 13, 2024
@juliamrch juliamrch changed the title chore: migrate from subdomain to clever-cloud.com/developers chore: migrate from subdomain to www.clever-cloud.com/developers Nov 13, 2024
@github-actions
Copy link

🚀 You updated your review app. Check it here

@github-actions
Copy link

🚀 You updated your review app. Check it here

@github-actions
Copy link

🚀 You updated your review app. Check it here

@github-actions
Copy link

🚀 You updated your review app. Check it here

@github-actions
Copy link

🚀 You updated your review app. Check it here

@juliamrch
Copy link
Contributor Author

We are so ready
Capture d’écran 2024-12-17 à 10 39 33

@github-actions
Copy link

🚀 You updated your review app. Check it here

@juliamrch juliamrch marked this pull request as ready for review December 17, 2024 09:49
@github-actions
Copy link

🚀 You updated your review app. Check it here

@github-actions
Copy link

🚀 You updated your review app. Check it here

@github-actions
Copy link

🚀 You updated your review app. Check it here

@cnivolle cnivolle merged commit b6e8733 into main Dec 17, 2024
4 checks passed
@cnivolle cnivolle deleted the new-root branch December 17, 2024 14:55
@github-actions
Copy link

You closed this PR and deleted the review app 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants