Keycloak/Metabase access domain #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋` Review app deletedYou closed this PR and deleted the review app. |
davlgd
force-pushed
the
davlgd-changelog-access-domain-kc-mb
branch
from
10fc122 to
8a5a08c
Compare
davlgd
changed the title
davlgd
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates documentation and adds changelog entries to document the new access-domain option for configuring custom domains when creating Keycloak, Metabase, and Otoroshi add-ons. The change standardizes the option name from base-domain to access-domain for Otoroshi and introduces this functionality for Keycloak and Metabase.
- Standardizes domain configuration option naming to
access-domainacross all three add-on types - Adds two new changelog entries announcing custom domain configuration capability for Keycloak and Metabase
- Updates existing documentation to reflect the new option names and functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| content/doc/addons/otoroshi.md | Updates base-domain to access-domain in documentation and examples |
| content/doc/addons/metabase.md | Adds new section documenting access-domain option for custom domain configuration |
| content/doc/addons/keycloak.md | Adds new section documenting access-domain option for custom domain configuration |
| content/changelog/2025/12-23-metabase-set-domain.md | New changelog entry announcing Metabase custom domain feature |
| content/changelog/2025/12-04-keycloak-set-domain.md | New changelog entry announcing Keycloak custom domain feature |
| content/changelog/2025/11-28-otoroshi-set-domains.md | Updates base-domain to access-domain in existing Otoroshi changelog entry |
allemas
reviewed
Dec 24, 2025
davlgd
force-pushed
the
davlgd-changelog-access-domain-kc-mb
branch
from
7dc6d42 to
2b51791
Compare
davlgd
force-pushed
the
davlgd-changelog-access-domain-kc-mb
branch
from
2b51791 to
b2ae1df
Compare
allemas
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 What does this PR do?
This PR adds entries about access domain option for KC/MB
🧪 Type of Change
✅ Quick Checklist
👥 Reviewers
@allemas