Skip to content

fix T_in in TRMM_LBA#33

Open
yairchn wants to merge 1 commit intomainfrom
yc/fix_trmm
Open

fix T_in in TRMM_LBA#33
yairchn wants to merge 1 commit intomainfrom
yc/fix_trmm

Conversation

@yairchn
Copy link
Member

@yairchn yairchn commented Jun 5, 2022

the initial T profile in TRMM has a very strange (wrong) she at 15km and this change would make it more physical

@yairchn yairchn requested a review from charleskawczynski June 5, 2022 05:37
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #33 (b0ac70d) into main (15a8aed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          207       207           
=========================================
  Hits           207       207           
Impacted Files Coverage Δ
src/profiles/TRMM_LBA.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a8aed...b0ac70d. Read the comment docs.

@yairchn
Copy link
Member Author

yairchn commented Jun 5, 2022

the current profile
Screen Shot 2022-06-04 at 10 38 44 PM

@yairchn
Copy link
Member Author

yairchn commented Jun 5, 2022

the new profile
Screen Shot 2022-06-04 at 10 39 18 PM

@charleskawczynski
Copy link
Member

Fine to merge, can we just mention where the new data is coming from? I think the original profiles came from scampy? But I do remember seeing multiple versions when moving things here.

@yairchn
Copy link
Member Author

yairchn commented Jun 5, 2022

I manually adjusted the value for a smooth profile , the original profile is from the paper but in that paper the convection does not reach 15km so it probably does not matter there. @trontrytel @ilopezgp what do you think ?

@yairchn yairchn requested a review from ilopezgp June 5, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants