Skip to content

Store structure matrices and vectors with names as dictionaries#373

Merged
ArneBouillon merged 14 commits intomainfrom
ab/struct-mat-dict
Aug 25, 2025
Merged

Store structure matrices and vectors with names as dictionaries#373
ArneBouillon merged 14 commits intomainfrom
ab/struct-mat-dict

Conversation

@ArneBouillon
Copy link
Collaborator

@ArneBouillon ArneBouillon commented Jul 21, 2025

  • Add structure vectors along with structure matrices
  • Store structure matrices and vectors in dictionaries, so that they can be named in case a specific matrix/vector is needed
  • I'm not entirely convinced by my solution of passing encoder_kwargs to Emulator, but I don't really have a better idea. Let me know if you do!

Misc:

  • build_models! now only accepts the expected keyword arguments, throws errors if unknown kwargs are passed.

@ArneBouillon ArneBouillon requested a review from odunbar July 22, 2025 17:36
@ArneBouillon ArneBouillon changed the title Store structure matrices with names as dictionaries Store structure matrices and vectors with names as dictionaries Aug 19, 2025
@ArneBouillon ArneBouillon marked this pull request as ready for review August 19, 2025 11:02
@ArneBouillon ArneBouillon requested a review from odunbar August 19, 2025 11:02
Copy link
Member

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the progress - this looks great. I have left a few small comments.

  • I do notice that the buildkite fails, Presumably we need to update a few of the examples. The specific failures it hits are on the Lorenz and the Regression examples - failing due to
    • (1) Please provide a structure matrix
    • (2) no method matching build_models!(::GaussianProcess{SKLJL, Float64, Vector{Float64}}, ::PairedDataContainer{Float64}, ::Dict{Symbol, Union{UniformScaling, AbstractMatrix}}, ::Dict{Symbol, Union{UniformScaling, AbstractMatrix}}; input_structure_matrix::Diagonal{Float64, Vector{Float64}}, output_structure_matrix::Matrix{Float64})

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.98%. Comparing base (a318edb) to head (9abb476).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/Utilities.jl 90.90% 4 Missing ⚠️
src/GaussianProcess.jl 86.66% 2 Missing ⚠️
src/ScalarRandomFeature.jl 80.00% 1 Missing ⚠️
src/VectorRandomFeature.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   90.80%   90.98%   +0.18%     
==========================================
  Files          10       10              
  Lines        1577     1609      +32     
==========================================
+ Hits         1432     1464      +32     
  Misses        145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArneBouillon ArneBouillon requested a review from odunbar August 20, 2025 12:36
Copy link
Member

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could resolve the last codecov requests, this looks good to me! Thanks!

@ArneBouillon ArneBouillon merged commit 14e03ab into main Aug 25, 2025
9 checks passed
@ArneBouillon ArneBouillon deleted the ab/struct-mat-dict branch August 25, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants