Store structure matrices and vectors with names as dictionaries#373
Merged
ArneBouillon merged 14 commits intomainfrom Aug 25, 2025
Merged
Store structure matrices and vectors with names as dictionaries#373ArneBouillon merged 14 commits intomainfrom
ArneBouillon merged 14 commits intomainfrom
Conversation
odunbar
reviewed
Jul 23, 2025
odunbar
reviewed
Jul 23, 2025
odunbar
reviewed
Jul 23, 2025
cde5b82 to
8152241
Compare
odunbar
reviewed
Aug 19, 2025
Member
There was a problem hiding this comment.
Hey! Thanks for the progress - this looks great. I have left a few small comments.
- I do notice that the buildkite fails, Presumably we need to update a few of the examples. The specific failures it hits are on the Lorenz and the Regression examples - failing due to
- (1)
Please provide a structure matrix - (2)
no method matching build_models!(::GaussianProcess{SKLJL, Float64, Vector{Float64}}, ::PairedDataContainer{Float64}, ::Dict{Symbol, Union{UniformScaling, AbstractMatrix}}, ::Dict{Symbol, Union{UniformScaling, AbstractMatrix}}; input_structure_matrix::Diagonal{Float64, Vector{Float64}}, output_structure_matrix::Matrix{Float64})
- (1)
ArneBouillon
commented
Aug 20, 2025
c9ed926 to
6d1b6df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 90.80% 90.98% +0.18%
==========================================
Files 10 10
Lines 1577 1609 +32
==========================================
+ Hits 1432 1464 +32
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArneBouillon
commented
Aug 20, 2025
odunbar
approved these changes
Aug 21, 2025
Member
odunbar
left a comment
There was a problem hiding this comment.
If you could resolve the last codecov requests, this looks good to me! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encoder_kwargstoEmulator, but I don't really have a better idea. Let me know if you do!Misc:
build_models!now only accepts the expected keyword arguments, throws errors if unknown kwargs are passed.