Generate atmos target grid for wxquest_initial_conditions#156
Merged
nefrathenrici merged 1 commit intomainfrom Apr 10, 2026
Merged
Generate atmos target grid for wxquest_initial_conditions#156nefrathenrici merged 1 commit intomainfrom
nefrathenrici merged 1 commit intomainfrom
Conversation
1e96955 to
8acad86
Compare
ph-kev
approved these changes
Apr 9, 2026
Comment on lines
+40
to
+41
| defDim(ds, "lon", 384) | ||
| defDim(ds, "lat", 192) |
Member
There was a problem hiding this comment.
I was wondering if you knew why these exact numbers were chosen.
Member
Author
There was a problem hiding this comment.
This is the number of points in the grid at /net/sampo/data1/wxquest_data/coupler_grids/zg_3h_inst_helem_32_zelem_63_output_at_levels_true.nc, which was originally used to generate the initial condition files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the wxquest_initial_conditions artifact.
Previously the atmosphere grid file was assumed to exist at a hardcoded /net/sampo path. Now we generate it programmatically from equispaced lon/lat (linspace -180:180 x384, -90:90 x192, verified against the original file on sampo), download ERA5 at model levels, and pass the grid file explicitly to preprocessing.jl.