Open
Conversation
kmdeck
reviewed
Apr 15, 2026
| ] | ||
|
|
||
| preprocess_dict = | ||
| Dict("reco.nc" => reco_reverse_dim, "nee.nc" => nee_reverse_dim) |
Member
There was a problem hiding this comment.
I think it might be simpler to, instead of defining these in the other file:
reco_reverse_dim() = reverse_lat_dim("reco.nc", "reco")
nee_reverse_dim() = reverse_lat_dim("nee.nc", "nee")
just call them here
Suggested change
| Dict("reco.nc" => reco_reverse_dim, "nee.nc" => nee_reverse_dim) | |
| Dict("reco.nc" => reverse_lat_dim("reco.nc", "reco"), "nee.nc" => reverse_lat_dim("nee.nc", "nee") |
kmdeck
reviewed
Apr 15, 2026
| [https://www.ilamb.org/ILAMB-Data/](https://www.ilamb.org/ILAMB-Data/) | ||
|
|
||
| ### 1. `reco_FLUXCOM_reco.nc` | ||
| This `.nc` file is the FLUXCOM dataset containing observational data for ecosystem |
Member
There was a problem hiding this comment.
Could you note the units for both?
kmdeck
approved these changes
Apr 15, 2026
Member
kmdeck
left a comment
There was a problem hiding this comment.
this looks good! do you think it makes sense to leave this as an ILAMB artifact (no specific respiration_NEE in the name) and then we can add more stuff to it if we need to? (e.g. instead of having to make a new artifact for ILAMB soil water, or ILAMB runoff)...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
$artifact_nameREADME.mdin that that folder thatLICENSEfileProject.tomland
Manifest.toml)OutputArtifacts.tomlfile containing the informationneeded for package developers to add
$artifact_nameto their package/resnick/groups/esm/ClimaArtifacts/artifacts/$artifact_name)Overides.tomlon the Caltech Cluster(in
/resnick/groups/esm/ClimaArtifacts/artifacts/Overrides.toml)README.mdto point to the new artifact