Add ObservationRecipe.reconstruct_g_mean_final#197
Merged
Conversation
ph-kev
changed the title
ph-kev
force-pushed
the
kp/reconstruct
branch
2 times, most recently
from
43872aa to
02bc83a
Compare
ph-kev
changed the title
ph-kev
force-pushed
the
kp/reconstruct
branch
2 times, most recently
from
16896a8 to
fda4bf7
Compare
ph-kev
commented
Jul 29, 2025
ext/ClimaAnalysisExt.jl
Outdated
Comment on lines
533
to
536
| num_epoches = EKP.get_length_epoch(obs_series) | ||
| minibatch_indices = EKP.get_minibatch(obs_series, mod1(N, num_epoches)) |
Member
Author
There was a problem hiding this comment.
I wasn't sure if there is a better way of doing this with EKP.
ph-kev
force-pushed
the
kp/reconstruct
branch
4 times, most recently
from
45c0c8e to
eac7088
Compare
nefrathenrici
approved these changes
Jul 31, 2025
Member
nefrathenrici
left a comment
nefrathenrici
left a comment
There was a problem hiding this comment.
Thank you! This will be nice to have. I just left some small comments.
3 tasks
ph-kev
force-pushed
the
kp/reconstruct
branch
3 times, most recently
from
d078e5d to
5df2ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ObservationRecipe.reconstruct_g_mean_final.TODO
_get_metadata_from_nth_iteration