Skip to content

Add ObservationRecipe.reconstruct_vars#252

Merged
ph-kev merged 4 commits intomainfrom
kp/var-from-obs
Oct 29, 2025
Merged

Add ObservationRecipe.reconstruct_vars#252
ph-kev merged 4 commits intomainfrom
kp/var-from-obs

Conversation

@ph-kev
Copy link
Member

@ph-kev ph-kev commented Oct 21, 2025

closes #251 - This PR adds ObservationRecipe.reconstruct_vars which reconstruct OutputVars from an EKP.Observation. The use of this function is for debugging calibration.

TODO

  • Add tests

@ph-kev ph-kev force-pushed the kp/var-from-obs branch 2 times, most recently from 88e58cd to 632d28e Compare October 21, 2025 19:04
@ph-kev ph-kev requested a review from nefrathenrici October 21, 2025 19:04
@ph-kev ph-kev marked this pull request as ready for review October 21, 2025 20:01
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you export reconstruct_vars and add some documentation about this feature to observation_recipe.md?

@ph-kev ph-kev force-pushed the kp/var-from-obs branch 4 times, most recently from 7537bb8 to c0e1c35 Compare October 22, 2025 16:57
@ph-kev ph-kev requested a review from nefrathenrici October 22, 2025 17:01
@ph-kev ph-kev force-pushed the kp/var-from-obs branch 2 times, most recently from ccc630c to f650064 Compare October 28, 2025 17:11
@ph-kev ph-kev merged commit df562e8 into main Oct 29, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ObservationRecipe.reconstruct_vars

2 participants