Skip to content

Fix bug with SignChecker when NaNs are present #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ph-kev merged 1 commit into from
Oct 29, 2025
Merged

Fix bug with SignChecker when NaNs are present #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ext/checkers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ function Checker.check(
# This is inaccurate, because not all the values in var.data will end up in
# the G ensemble matrix. See _match_dates for one case. However, the mean
# should not change that much with additional times.
sim_pos_proportion = nanmean(var.data .> 0)
valid = @. !isnan(var.data)
sim_pos_proportion = sum(valid .& (var.data .> 0)) / sum(valid)

same_sign = abs(obs_pos_proportion - sim_pos_proportion) < checker.threshold
!same_sign &&
Expand Down
11 changes: 11 additions & 0 deletions test/ensemble_builder.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,17 @@ import ClimaAnalysis.Template:
data = make_flat_data(neg_var),
)

# Check case with NaN
nan_data = collect(Float64.(copy(var.data)))
nan_data[1] = NaN
nan_var = ClimaAnalysis.remake(var, data = nan_data)
@test Checker.check(
sign_checker,
nan_var,
make_metadata(var),
data = make_flat_data(var),
)

@test_logs (:info, r"Proportion of positive values in the simulation data ") Checker.check(
sign_checker,
var,
Expand Down
Loading