Tr/minor fixes - #2347
Merged
Merged
Conversation
imreddyTeja
force-pushed
the
tr/minor-fixes
branch
from
June 24, 2025 17:06
d3a76c4 to
4218bcc
Compare
imreddyTeja
force-pushed
the
tr/minor-fixes
branch
from
June 24, 2025 20:03
3f6b36f to
8655655
Compare
akshaysridhar
approved these changes
Jun 26, 2025
dennisYatunin
approved these changes
Jun 27, 2025
dennisYatunin
left a comment
dennisYatunin
left a comment
Member
There was a problem hiding this comment.
I'd recommend bumping the UnrolledUtilities version to 0.1.9, since that will slightly improve latency compared to 0.1.8. The corrections and new tests in this PR look good to me!
Member
|
Thanks @imreddyTeja ! Please squash the commits, then this is ready to be merged. |
Bump UnrolledUtilities compat Fix inconsistent tensor indexing behavior Fix field2array error message Add tests for level function on Fields Also add `issubspace` for `FiniteDifferenceSpaces` The test currently fails because an error is not thrown for face spaces when out of bounds indexing. remove issubspace Remove `@inbounds` from `level` function `level` on a field on cell faces does not throw errors when attempting to access a level outside the space. This fixes that, but there may be a performance penalty. Simplify AxisTensor idxin function The previous idxin method for a 1d axis tensor behaved different that non singlular dimension axistensors. This commit unifies all the different methods by using unrolled_findfirst Bump UnrolledUtilities compat Simplify level bounds tests Bump UnrolledUtilities again
imreddyTeja
force-pushed
the
tr/minor-fixes
branch
from
June 27, 2025 16:55
8655655 to
4a89691
Compare
imreddyTeja
enabled auto-merge (rebase)
June 27, 2025 16:55
imreddyTeja
disabled auto-merge
June 27, 2025 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses three issues:
field2arrayis called with incompatible elements.levelfunction does not throwBoundsErrorsFor the first issue, the message itself is corrected.
For the second issue, tests are added for
level(::Field).The fix for the second issue requires removing an
@inbounds, so there may be a performance penalty.This PR also bumps the UnrolledUtilities compat to v0.1.8. v0.1.7 adds a lot of useful unrolled_functions, including
unrolled_findfirst, but the downgrade will throw JET errors unless using v0.1.8Closes #2337
Closes #2320
Closes #2348