Tr/rm bcs - #2521
Open
imreddyTeja wants to merge 20 commits into
Open
Conversation
imreddyTeja
force-pushed
the
tr/rm-bcs
branch
6 times, most recently
from
June 3, 2026 18:27
3cbaec7 to
5cba998
Compare
imreddyTeja
force-pushed
the
tr/rm-bcs
branch
2 times, most recently
from
June 10, 2026 22:44
d7d5be8 to
b7adf2d
Compare
imreddyTeja
force-pushed
the
tr/rm-bcs
branch
3 times, most recently
from
June 17, 2026 23:12
e5a117d to
19ac42c
Compare
imreddyTeja
marked this pull request as ready for review
June 17, 2026 23:15
Member
|
Thanks @imreddyTeja. I looked over the artifacts (and updated docstrings) in the |
The reference values in the "Replacements for removed operators and boundary conditions" testset are built with scalar indexing, so extract the data they are built from (and the results they are compared against) on the CPU. Also apply the biased operators to `ᶠlg.J` rather than to `ᶠlg`: the GPU compiles the never-taken `NullBoundaryCondition` branch of the stencil, which multiplies by `NaN` and so cannot handle a `LocalGeometry` element type. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xn8GWgn2mufFccq5MMKPCS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetValuefromGradientC2F,DivergenceC2F,CurlC2F,UpwindBiasedProductC2FSetGradientfromInterpolateC2FandWeightedInterpolateC2FAdvectionC2C,AdvectionF2F,FluxCorrectionF2F, andFluxCorrectionC2CoperatorsThe
stepexample is now merged with the advection example.TODO: Add a compat for ClimaCore to KinematicDrivers.jl