Unify stong/weak forms with type parameter dispatch - #2556
Merged
Conversation
Member
Author
|
Needs #2557 before merging, to fix race condition in Datalayouts/scopes.jl. |
dennisYatunin
approved these changes
Jul 29, 2026
dennisYatunin
left a comment
dennisYatunin
left a comment
Member
There was a problem hiding this comment.
Thanks for simplifying this! I only have one small comment about code duplication; looks great otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Divergence,Gradient, andCurlnow take a second type parameter (StrongForm/WeakForm) that factors out the three form-dependent differences (transposed-and-negated derivative matrix, W-weighted input, J vs WJ rescale). The twelve strong/weakapply_operatormethods reduce to six;WeakDivergence,WeakGradient, andWeakCurlbecome backwards-compatibility aliases collected insrc/Operators/deprecated.jlfor later removal.