Fix tail effect on GPUs - #2558
Open
dennisYatunin wants to merge 1 commit into
Open
Conversation
dennisYatunin
force-pushed
the
dy/tail_effect
branch
from
July 28, 2026 01:25
bb43d50 to
a899e50
Compare
Member
|
This does fix the tail effect, but it does not give the 50% speedup that ncu thought it would. It still says the average active warps increased by 1. It does give a small speed up. I'm a bit concerned about how this will impact ClimaLand though. I'd guess the extra dictionary usage might impact latency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
max_resident_blocksto account for register pressure and shared memory requirements, fixing the "tail effect" problem that was introduced in #2522 for 64-level pointwise kernels (see this comment for details).