use TripolarGrid and ConservativeRegridding for CMIP#1840
Open
juliasloan25 wants to merge 2 commits intomainfrom
Open
use TripolarGrid and ConservativeRegridding for CMIP#1840juliasloan25 wants to merge 2 commits intomainfrom
juliasloan25 wants to merge 2 commits intomainfrom
Conversation
juliasloan25
force-pushed
the
js/tripolar-conservative-march2026
branch
2 times, most recently
from
301bbc3 to
bb56a5e
Compare
Comment on lines
+19
to
+40
| function OC.Fields.set_to_array!( | ||
| u::OC.Field{LX, <:OC.Grids.Center, LZ, O, <:TGRF}, | ||
| a, | ||
| ) where {LX, LZ, O} | ||
| a = OC.Architectures.on_architecture(OC.Architectures.CPU(), a) | ||
| a = resize_to_facefolded(a) | ||
| a = OC.Architectures.on_architecture(OC.Architectures.architecture(u), a) | ||
|
|
||
| try | ||
| copyto!(OC.interior(u), a) | ||
| catch err | ||
| if err isa DimensionMismatch | ||
| Nx, Ny, Nz = size(u) | ||
| u .= reshape(a, Nx, Ny, Nz) | ||
|
|
||
| msg = string("Reshaped ", summary(a), " to set! its data to ", '\n', summary(u)) | ||
| @warn msg | ||
| else | ||
| throw(err) | ||
| end | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
From oceananigans 0.106.3 this is not required anymore
juliasloan25
force-pushed
the
js/tripolar-conservative-march2026
branch
from
bb56a5e to
4b5b196
Compare
juliasloan25
force-pushed
the
js/tripolar-conservative-march2026
branch
from
4b5b196 to
5cc77a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
new version of #1724
includes the following fixes:
To-do
Content