Open
Conversation
c7b5f68 to
76d30b9
Compare
b6e95a0 to
6189048
Compare
6189048 to
2082142
Compare
kmdeck
reviewed
Feb 26, 2026
kmdeck
reviewed
Feb 26, 2026
kmdeck
reviewed
Feb 26, 2026
| # Global noise variances (computed across all calibration years) | ||
| all_cal_mask = | ||
| (Date(first(cal_years), 1, 1) .<= flux_dates .<= Date(last(cal_years), 12, 31)) | ||
| nee_var = mean(filter(!isnan, nee_uc_raw[all_cal_mask] .^ 2)) |
Member
There was a problem hiding this comment.
we may need to further scale nee_var by a constant to wait terms in the loss function equally. In our offline run with default parameters, the weighted RMSE for need is about 20x larger than the weighted RMSE for the heat fluxes.
julia> x = (lhf_model_at_obs .- qle_obs)./qle_unc;
julia> @show sqrt(mean(x.^2)), mean(x)
(6.310226345552107, -1.9822982854949414)
julia> x = (shf_model_at_obs .- qh_obs)./qh_unc;
julia> @show sqrt(mean(x.^2)), mean(x)
(5.226855236254443, 2.479323425387818)
julia> x = (nee_model_at_obs .- nee_obs)./nee_unc;
julia> @show sqrt(mean(x.^2)), mean(x)
(108.79570442024037, 19.221651412031065)
That is, we might want to scale the NEE uncertainty by 108/620.
Member
Author
There was a problem hiding this comment.
I'll leave this open for consideration... I'll try running as is for now
kmdeck
reviewed
Feb 26, 2026
kmdeck
reviewed
Feb 26, 2026
kmdeck
reviewed
Feb 26, 2026
kmdeck
reviewed
Feb 26, 2026
86121bb to
ea0290f
Compare
c116a4b to
ac4c927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO DO:
wip