Draft
Conversation
dfba256 to
beda49c
Compare
6e43877 to
31eda87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO DO:
make a plot of lake depth to make sure it looks good... if a pixel has IMERG mask (is a lake) but no depth, make it 10 m
if era5 lake depth exist, consider that pixel a lake, even if IMERG doesn't
use f (not binary) (IMERG should also be possible to convert to f?)
Add ERA5 lake depth as a
SpaceVaryingInput, replacing the previous constant 10 m depth. The depth field is read from theera5_lake_cover_and_depthartifact (dlvariable) and stored on theSlabLakeModelstruct.Add a tunable
slab_lake_depth_scale_factorparameter (α, default 1) so thatdepth_slab = α × depth_ERA5. Where the IMERG mask identifies inland water but ERA5 depth is zero or missing, the depth falls back toslab_lake_depth(10 m).Parameterization functions (
lake_energy_at_freezing,lake_liquid_fraction,lake_energy_from_temperature,lake_temperature) now takedepthas a separate positional argument to support spatially varying depth.Add
era5_lake_cover_path()andera5_lake_depth_path()artifact accessors.The inland water mask still uses the IMERG land-sea mask (ERA5 lake cover misses some water bodies like the Black Sea).