Fix UI of Metadata
#693
Open
Fix UI of Metadata
#693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-silvestri
commented
Dec 2, 2025
simone-silvestri
requested review from
glwagner and
navidcy
and removed request for
glwagner
glwagner
reviewed
Dec 2, 2025
Member
glwagner
left a comment
glwagner
left a comment
There was a problem hiding this comment.
I'm confused about the UI here. Shouldn't we not have dates kwarg? The purpose of having start/end date is to relieve the user from having to know the frequency. Or, we should get rid of start/end date? I prefer having start/end though.
Collaborator
Author
|
I also prefer that, but the |
Member
Ah good point about ability to exclude points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if passing only one of
start_dateorend_date, the dates where not cropped.This PR fixes this.
I need to add one test.