Skip to content

Updated reference temperature to reflect dycore manuscript#253

Open
ray-chew wants to merge 1 commit into
mainfrom
rc/update_refs
Open

Updated reference temperature to reflect dycore manuscript#253
ray-chew wants to merge 1 commit into
mainfrom
rc/update_refs

Conversation

@ray-chew

Copy link
Copy Markdown
Member

Purpose and content

In the manuscript, we changed temperature_surface_reference to 288 K and temperature_min_reference to 215 K, respectively. This PR synchronises the default parameters with those in the manuscript.

To-do

Content


  • I have read and checked the items on the review checklist.

@codecov

codecov Bot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.76%. Comparing base (0031b92) to head (f739f9e).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files           1        1           
  Lines         130      130           
=======================================
  Hits          118      118           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akshaysridhar

Copy link
Copy Markdown
Member

@nefrathenrici ClimaAtmos Project.toml currently tracks ClimaParams v1 - should this be more restrictive ?

@tapios tapios left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you like to add the exponent parameter (e.g., 'temperature_reference_decay_exponent' (=7) in this same PR, so we have it all?

@nefrathenrici nefrathenrici left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you update the NEWS.md as well?

@ray-chew

Copy link
Copy Markdown
Member Author

Thank you! Could you update the NEWS.md as well?

Oh, thanks for reminding me! Done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants