Updated reference temperature to reflect dycore manuscript#253
Open
ray-chew wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 1 1
Lines 130 130
=======================================
Hits 118 118
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@nefrathenrici ClimaAtmos Project.toml currently tracks |
akshaysridhar
approved these changes
Sep 24, 2025
tapios
approved these changes
Sep 24, 2025
tapios
left a comment
Member
There was a problem hiding this comment.
LGTM. Would you like to add the exponent parameter (e.g., 'temperature_reference_decay_exponent' (=7) in this same PR, so we have it all?
19c396c to
8e915d8
Compare
nefrathenrici
approved these changes
Sep 25, 2025
nefrathenrici
left a comment
Member
There was a problem hiding this comment.
Thank you! Could you update the NEWS.md as well?
8e915d8 to
a1b5c50
Compare
a1b5c50 to
f739f9e
Compare
Member
Author
Oh, thanks for reminding me! Done. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and content
In the manuscript, we changed
temperature_surface_referenceto288 Kandtemperature_min_referenceto215 K, respectively. This PR synchronises the default parameters with those in the manuscript.To-do
Content