Skip to content

rft: normalize some CM parameter units#295

Merged
haakon-e merged 1 commit into
mainfrom
he/rft-normalize-some-cm-parameter
Jun 22, 2026
Merged

rft: normalize some CM parameter units#295
haakon-e merged 1 commit into
mainfrom
he/rft-normalize-some-cm-parameter

Conversation

@haakon-e

@haakon-e haakon-e commented Jun 22, 2026

Copy link
Copy Markdown
Member

closes #294

@haakon-e haakon-e force-pushed the he/rft-normalize-some-cm-parameter branch 4 times, most recently from a89b30b to fa248c0 Compare June 22, 2026 22:05
@haakon-e haakon-e requested a review from trontrytel June 22, 2026 22:05
@haakon-e

Copy link
Copy Markdown
Member Author

cc: @trontrytel. xref: CliMA/CloudMicrophysics.jl#736

Barklie Gokhale 1959 parameters for CloudMicrophysics.jl
converted to SI units. used in 2M microphysics, which
has no downstream consumers, so this is considered
non-breaking.
@haakon-e haakon-e force-pushed the he/rft-normalize-some-cm-parameter branch from fa248c0 to dd5acef Compare June 22, 2026 23:16
@haakon-e haakon-e enabled auto-merge June 22, 2026 23:16
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.78%. Comparing base (23309cd) to head (dd5acef).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files           1        1           
  Lines         146      146           
=======================================
  Hits          134      134           
  Misses         12       12           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haakon-e haakon-e merged commit 85accf6 into main Jun 22, 2026
17 checks passed
@haakon-e haakon-e deleted the he/rft-normalize-some-cm-parameter branch June 22, 2026 23:46
haakon-e added a commit to CliMA/CloudMicrophysics.jl that referenced this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert Barklie Gokhale 1959 parameters standard units

2 participants