Add options for NonEq relaxation timescales as functions of N and T#676
Draft
Add options for NonEq relaxation timescales as functions of N and T#676
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 94.58% 94.37% -0.21%
==========================================
Files 53 53
Lines 2251 2258 +7
==========================================
+ Hits 2129 2131 +2
- Misses 122 127 +5
🚀 New features to boost your workflow:
|
oalcabes
changed the title
oalcabes
force-pushed
the
oa/tau_i_temp_dependence
branch
3 times, most recently
from
cf55a81 to
9346e0c
Compare
trontrytel
reviewed
Feb 14, 2026
trontrytel
reviewed
Feb 14, 2026
| MicrophysicsNonEq.τ_relax | ||
| MicrophysicsNonEq.conv_q_vap_to_q_lcl_icl | ||
| MicrophysicsNonEq.conv_q_vap_to_q_lcl_MM2015 | ||
| MicrophysicsNonEq.conv_q_vap_to_q_icl_MM2015 |
Member
There was a problem hiding this comment.
Do we still want to keep MicrophysicsNonEq.conv_q_vap_to_q_icl_MM2015?
Member
Author
There was a problem hiding this comment.
Ideally we would keep "MicrophysicsNonEq.conv_q_vap_to_q_lcl_MM2015" and "MicrophysicsNonEq.conv_q_vap_to_q_icl_MM2015" and delete "MicrophysicsNonEq.conv_q_vap_to_q_lcl_icl_MM2015" - I was leaving it now for backwards compatibility but if we're okay with a breaking release I can just delete it
trontrytel
reviewed
Feb 14, 2026
|
|
||
| # Using same limiter as ClimaAtmos for now | ||
| # Not sure why, but without intermediate storing of the tendencies for the | ||
| # if/else branch this code segfaults on julia v1.11 (works fine on v1.10) |
Member
There was a problem hiding this comment.
No idea. But I have seen this before too :/
oalcabes
force-pushed
the
oa/tau_i_temp_dependence
branch
from
0e64b5e to
ab706fb
Compare
Co-authored-by: Anna Jaruga <ajaruga@caltech.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to make new versions of the NonEq scheme, namely tau(T) and tau(N) functionality. Still need to review docs and think carefully about testing, but I'd love comments and thoughts on the PR! This may break atmos as I've made changes to the bulk_microphysics_tendency function.