Skip to content

Use condensate in evaporation/sublimation#708

Merged
trontrytel merged 1 commit intomainfrom
aj/evaporation_fix
Mar 25, 2026
Merged

Use condensate in evaporation/sublimation#708
trontrytel merged 1 commit intomainfrom
aj/evaporation_fix

Conversation

@trontrytel
Copy link
Copy Markdown
Member

@trontrytel trontrytel commented Mar 25, 2026

Writes evaporation and sublimation as proportional to the condensate mass. Deposition and condensation are still proportional to saturation excess.

@trontrytel trontrytel self-assigned this Mar 25, 2026
@trontrytel trontrytel requested a review from sajjadazimi March 25, 2026 18:07
@trontrytel trontrytel added the Needs review Please review my pull request label Mar 25, 2026
@trontrytel trontrytel requested a review from oalcabes March 25, 2026 18:07
Copy link
Copy Markdown
Member

@sajjadazimi sajjadazimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trontrytel trontrytel added Approved 🍀 and removed Needs review Please review my pull request labels Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (e0496e3) to head (e6581c3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   92.10%   92.01%   -0.10%     
==========================================
  Files          54       54              
  Lines        2268     2242      -26     
==========================================
- Hits         2089     2063      -26     
  Misses        179      179              
Components Coverage Δ
src 93.01% <100.00%> (-0.09%) ⬇️
ext 69.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trontrytel trontrytel enabled auto-merge March 25, 2026 22:41
@trontrytel trontrytel merged commit be6d8df into main Mar 25, 2026
12 checks passed
@trontrytel trontrytel deleted the aj/evaporation_fix branch March 25, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants