Skip to content

Average bulk microphysics tendencies#711

Merged
sajjadazimi merged 1 commit intomainfrom
sa/add_average_bulk_1m_tendencies
Apr 16, 2026
Merged

Average bulk microphysics tendencies#711
sajjadazimi merged 1 commit intomainfrom
sa/add_average_bulk_1m_tendencies

Conversation

@sajjadazimi
Copy link
Copy Markdown
Member

Purpose

Add average bulk microphyiscs 1m tendency based on linearized microphysics:

  • Transfers → D * q_donor
  • Vapor sources → constants
  • Sinks → -D * q (exponential decay over time);

  • I have read and checked the items on the review checklist.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (91a04fe) to head (707ee19).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   92.01%   92.52%   +0.50%     
==========================================
  Files          54       54              
  Lines        2242     2394     +152     
==========================================
+ Hits         2063     2215     +152     
  Misses        179      179              
Components Coverage Δ
src 93.47% <100.00%> (+0.46%) ⬆️
ext 69.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sajjadazimi sajjadazimi force-pushed the sa/add_average_bulk_1m_tendencies branch from 979bc81 to 986667f Compare April 14, 2026 18:50
@sajjadazimi sajjadazimi requested a review from trontrytel April 14, 2026 18:51
Comment thread src/BulkMicrophysicsTendencies.jl Outdated
Comment thread src/BulkMicrophysicsTendencies.jl Outdated
Comment thread src/BulkMicrophysicsTendencies.jl Outdated
Comment thread src/BulkMicrophysicsTendencies.jl
Comment thread src/BulkMicrophysicsTendencies.jl
Comment thread test/bulk_tendencies_tests.jl
Copy link
Copy Markdown
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hitting approve, so I don't slow you down when away!

@sajjadazimi sajjadazimi force-pushed the sa/add_average_bulk_1m_tendencies branch from 986667f to f644840 Compare April 16, 2026 04:34
…ysics with optional sub-stepping: donor-based linearization (sinks as D*q, vapor sources constant); add operator construction and average tendency solve.
@sajjadazimi sajjadazimi force-pushed the sa/add_average_bulk_1m_tendencies branch from f644840 to 707ee19 Compare April 16, 2026 23:22
@sajjadazimi sajjadazimi merged commit c2610e0 into main Apr 16, 2026
16 checks passed
@sajjadazimi sajjadazimi deleted the sa/add_average_bulk_1m_tendencies branch April 16, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants