Clean up unnecessary splatting #4383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jl into ss/fix-performance-2
|
might be worthing lookikng at this commit |
simone-silvestri
changed the title
|
Ok, it seems that we have no performance hit, I was mistaken. However, this PR removes a lot of unnecessary splatting making the code clearer, so I would still consider merging it. |
|
(The |
simone-silvestri
added
benchmark performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have a performance issue related to the implicit solver. It is very difficult to diagnose. I tried to remove splatting where possible and the
Val(tracer_index)to see if that creates weird problems. This PR is open just to see if the tests speed up with this change.