Remove the HeptadiagonalSolver
#4386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-silvestri
added
the
🚨 DO NOT MERGE 🚨
Member
|
The perforamnce also doesn't matter if neither is used in practice. In that case they are merely placeholders for future development, so the question is which forms the better basis for future development --- not performance. |
Collaborator
Author
|
After improving the fill halos, I think this PR might be ready to be merged (if tests pass) |
…ns.jl into ss/remove-matrix-solver
Collaborator
Author
|
If someone still wants this feature inside oceananigans, speak now or forever hold your peace :) |
simone-silvestri
requested review from
ali-ramadhan,
jagoosw,
navidcy and
tomchor
simone-silvestri
removed
the
🚨 DO NOT MERGE 🚨
navidcy
reviewed
Sep 12, 2025
navidcy
reviewed
Sep 12, 2025
navidcy
reviewed
Sep 12, 2025
navidcy
approved these changes
Sep 12, 2025
Member
|
bump patch? |
Member
|
happy for this to be merged |
Member
true, its breaking. |
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make the PCG the default. We need some benchmarking before merging this PR, at the time this solver was implemented the PCG was extremely slow (about 3 times difference) which motivated implementing a new strategy.
A lot of time has passed, so this solver which is more memory demanding might not be necessary anymore, but before merging we should do some benchmarking.