Integrate Krylov.jl
for pressure solve
#4409
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to integrate
KrylovSolver
for the pressure solve which has been developed into Oceananigans for the nonhydrostatic model. I begun by developing a new solver calledKrylovPoissonSolver
, which is a Poisson solver which uses Krylov methods available in Krylov.jl.There are a few considerations on the design that I think would be helpful to hear your thoughts on:
ConjugateGradientPoissonSolver
andKrylovPoissonSolver
? Should we keep both methods, or deprecateConjugateGradientPoissonSolver
?src\Solvers\conjugate_gradient_poisson_solver.jl
, while putting the newKrylovPoissonSolver
insrc\Solvers\krylov_poisson_solver.jl
which is also compatible with the preconditioners we have. Should we reorganize the files so that we put preconditioners in a separate file? Then perhaps their relations would be clearer.Base.summary
I am happy to hear your thoughts on what's important!@glwagner @simone-silvestri @amontoison @tomchor