-
Notifications
You must be signed in to change notification settings - Fork 236
A rework for the advection module that (should) improve WENO performance #4434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… ss/optimize-weno
…igans.jl into ss/remove-stretched-coeffs
… ss/optimize-weno
Results of benchmarking:
|
…nto ss/optimize-weno
…nto ss/optimize-weno
This PR reworks how advection is implemented by passing a
reduced_order
integer to theinterpolate
functions.At the moment, upwind and centered reconstruction do not formally change; the ifelse that was upstream before in the
alt_interpolate
functions is just pushed downstream in the reconstruction function.For WENO, the reconstruction approach changes because the order is accounted for by changing the reconstruction coefficients and the smoothness coefficients.
This method should give us a boost in performance in the WENO case for bounded and immersed boundary grids, as there is much less computation to be performed. I will post some benchmarking later on.
This PR is still exploratory, so there is a bit of benchmarking and cleaning up to do.