Skip to content

Adding reciprocal metric in the z-direction #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

simone-silvestri
Copy link
Collaborator

This PR starts the work of introducing the reciprocal of the metrics starting from the easiest metric (the z direction) which is common to all the grids. Let's see what the effect of this change is.

I am a bit worried thought that we are increasing significantly the parameter space that we are passing to the GPU, so in this quest of improving the performance we might shoot ourselves in the feet

@simone-silvestri simone-silvestri changed the title Adding reciprocal of the z-direction Adding reciprocal metric in the z-direction Apr 26, 2025
@simone-silvestri simone-silvestri added the benchmark performance runs preconfigured benchamarks and spits out timing label Apr 26, 2025
@glwagner
Copy link
Member

I am a bit worried thought that we are increasing significantly the parameter space that we are passing to the GPU, so in this quest of improving the performance we might shoot ourselves in the feet

That's a good point. I guess we have to assess the benefit.

starting from the easiest metric (the z direction)

True that it's common to all grids, but its def not the easiest metric if you want to isolate the effect for just one grid...

@glwagner
Copy link
Member

I guess one solution is to eliminate the non-reciprocal metrics (eg compute those by taking reciprocal of reciprocal). They are only used in integrals (?) so maybe not as performance critical.

But yeah its a big change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark performance runs preconfigured benchamarks and spits out timing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants