-
Notifications
You must be signed in to change notification settings - Fork 241
Fix some FieldTimeSeries
indexing bugs
#4505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1dd0a04
Moves indexing of fts.times to CPU
loisbaker 44f59f3
Compares times range and array using vector norm
loisbaker bc56592
Computes a timescale `dt` for absolute time comparisons
loisbaker a2fb18e
Add a space
loisbaker 47c8d32
Add comment and change time increment label `dt` to `Δt`
loisbaker 792c523
Comment to explain why `times` array is converted to a range
loisbaker 5ed7b52
Change `dt` to `Δt`
loisbaker 2b246a2
Merge branch 'main' into fix-fts-indexing
glwagner 89a439a
Merge branch 'main' into fix-fts-indexing
navidcy 8c99bc0
Merge branch 'main' into fix-fts-indexing
navidcy a4ebe04
Apply suggestions from code review
navidcy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.