-
Notifications
You must be signed in to change notification settings - Fork 230
feat(arc): add ClickBench results for Arc on c6a.4xlarge #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to push a new update of this PR in a few minutes. Thank you for marking the issues.
…nd c6a.4xlarge in aws
This comment was marked as resolved.
This comment was marked as resolved.
Just updated the files and make it public the repo. Thanks. |
arc/benchmark.sh
Outdated
|
||
# Install Python and dependencies | ||
echo "Installing dependencies..." | ||
pip3 install fastapi uvicorn duckdb pyarrow requests gunicorn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires running pip
with --break-system-packages
.
Would it be possible to create a Python venv? See e.g. chdb/benchmark.sh for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we have in our start.sh in the repo, I'm adding to this script.
arc/benchmark.sh
Outdated
|
||
# Create API token for benchmark | ||
python3 << EOF | ||
from api.auth import AuthManager, Permission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the next error here:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: cannot import name 'Permission' from 'api.auth' (/data/ClickBench/arc/arc/api/auth.py)
I checked, there is indeed no Permission
class in file auth.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff, thank you for this, its old code, in our repo we have this right. Let me update it here too.
## Prerequisites | ||
|
||
- Ubuntu/Debian Linux (or compatible) | ||
- Python 3.11+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no prerequisites - the benchmark runs automatically on an empty AWS machine with Ubuntu AMI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. We’ll revisit the submission later this year. For now, we’re happy to have the benchmark numbers internally and will use them for our own reference. Once we release official binaries, we’ll try again to get included in ClickBench.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a problem, let's push this PR to ClickBench. The more systems included, the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexey-milovidov we just updated, we were able to run the benchmark.sh according to clickbench guidelines. Let me know if you have issues running, but shouldn't have any. Thank you.
No success so far:
|
However, it did something before:
|
Ok guys, the benchmark.sh is fixed and we put some results for no cached and cached for c6a.4xlarge with gp2 of 500gb in aws. Please, validate this and let me know. |
Thanks! Now it runs successfully. A few corrections are still needed, e.g.,
|
Ok, Thanks, this should be good now. |
Hey everyone,
We’re the new folks in the neighborhood, sharing ClickBench results for Arc, our time-series warehouse that’s launching soon.
I’ve made sure everything follows the benchmark requirements, but happy to adjust if needed.
Appreciate your work on this project!
– Ignacio