fix: properly define types of polymorphic components#1055
Merged
Conversation
🦋 Changeset detectedLatest commit: acb5c72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-kkuhxr0ec-clickhouse.vercel.app Built from commit: |
gjones
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Types for polymorphic components were broken since forever.
How?
Define types properly.
Note
Low Risk
Type-only fixes with no runtime logic changes; risk is limited to possible stricter or corrected compile-time errors for consumers.
Overview
Fixes polymorphic public typings for
Container,EllipsisContent,GridContainer,Link, andTextby omitting conflicts against each component’s own props interface (ContainerProps,TextProps, etc.) instead ofkeyof Ton the element type.Consumers get correct merging of the
componentprop with native/HTML props for a chosenT, without changing runtime behavior. A patch changeset is included for@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit acb5c72. Bugbot is set up for automated code reviews on this repo. Configure here.