fix ambiguous time bug #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genzgd
approved these changes
Nov 4, 2025
joe-clickhouse
deleted the
joe/585-pandas-ambiguoustimeerror-in-version-092
branch
meirdev
pushed a commit
to meirdev/clickhouse-connect
that referenced
this pull request
Nov 5, 2025
joe-clickhouse
added a commit
that referenced
this pull request
Nov 5, 2025
* add executor parameter to AsyncClient * add note to change log * fix: we only want to shutdown the executor if we created it * add a custom object to represent the sentinel * fix typing * add warning log when executor_threads and executor are used * fix ambiguous time bug (#587) * fix version import (#583) * fix version import * add missing type * add missing types * fix #586: inconsistent type hint * fix tls test path in contribution docs * revert playtest --------- Signed-off-by: Meir <[email protected]> Co-authored-by: Joe S <[email protected]> Co-authored-by: Marek Wiese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During DST fallback, the same time can occur twice. Without additional kwargs,
pd.DatetimeIndexcan't interpret ambiguous times. This is fixed by converting to UTC (which is never ambiguous) before removing the timezone, then re-localizing to UTC and converting back to the target timezone.Checklist
Delete items not relevant to your PR:
Closes #585