Close the async streaming response on the event loop thread - #941
Merged
Conversation
StreamingResponseSource.close() ran the producer task cancel and response.close() from the parser executor thread. Under TLS that raced the event loop handling a server connection abort and could raise AttributeError from asyncio's SSL shutdown instead of the real StreamFailureError. Schedule the cleanup with call_soon_threadsafe. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent cloud failure in test_mid_stream_exception_async.
StreamingResponseSource.close() runs on the parser executor thread. It cancelled the producer task and closed the aiohttp response directly, racing the event loop handling the server side connection abort. On TLS connections that could raise an AttributeError from asyncio's SSL shutdown instead of the real StreamFailureError. Cloud is the only TLS run, which is why it never reproduced locally.
The cleanup is now scheduled onto the event loop with call_soon_threadsafe, falling back to a direct call if the loop is gone. Adds a unit test that checks the response is closed on the loop thread.