Change build steps to follow Fivetran requirements#108
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
koletzilla
commented
Jul 6, 2026
| @@ -0,0 +1,27 @@ | |||
| name: 'Setup Go & Build' | |||
Contributor
Author
There was a problem hiding this comment.
This is just the old action.yml but renamed and focused on only doing the complete make build
koletzilla
commented
Jul 6, 2026
Comment on lines
4
to
+16
| UNAME_S := $(shell uname -s) | ||
| UNAME_M := $(shell uname -m) | ||
| ifeq ($(UNAME_S),Darwin) | ||
| GRPC_HOSTNAME := host.docker.internal | ||
| PROTOC_OS := osx | ||
| else | ||
| GRPC_HOSTNAME := 172.17.0.1 | ||
| PROTOC_OS := linux | ||
| endif | ||
| ifneq ($(filter $(UNAME_M),arm64 aarch64),) | ||
| PROTOC_ARCH := aarch_64 | ||
| else | ||
| PROTOC_ARCH := x86_64 |
Contributor
Author
There was a problem hiding this comment.
Needed to allow the wiki example: GOOS=linux GOARCH=amd64 make build
koletzilla
commented
Jul 6, 2026
|
|
||
| # Installs a pinned protoc version into .protoc/ so builds do not depend on | ||
| # whatever protoc happens to be on PATH. | ||
| install-protoc: |
Contributor
Author
There was a problem hiding this comment.
We used to install it separately. Now it's included in the build process as mentioned in the docs Installation of local dependencies (e.g., protoc)
BentsiLeviav
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56
Now
make buildcan be used to install all dependencies and have a working binary