Skip to content

Fix clickhouse proxy issue: hosts as query string DSN not parsed, also add alt_hosts support for DSN #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix clickhouse proxy issue: hosts as query string DSN not parsed, also add alt_hosts support for DSN #1546

wants to merge 3 commits into from

Conversation

kokizzu
Copy link
Contributor

@kokizzu kokizzu commented Apr 24, 2025 •
edited
Loading

Summary

some clickhouse proxy dsn use hosts (already on readme but not working) and/or alt_hosts, currently hosts not parsed into Addr, this causing settings considered a custom and those 2 key being injected when creating prepared statement, making prepared statements failing.

prepare: code: 115, message: Unknown setting alt_hosts
prepare: code: 115, message: Unknown setting hosts

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@kokizzu kokizzu changed the title fix clickhouse hosts as query string not parsed, also add alt_hosts Fix clickhouse proxy issue: hosts as query string DSN not parsed, also add alt_hosts support for DSN Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kokizzu